Skip to content
Commit 94850e2d authored by Joel Stanley's avatar Joel Stanley Committed by Greg Kroah-Hartman
Browse files

drm/aspeed: Fix vga_pw sysfs output

[ Upstream commit b4a6aaea ]

Before the drm driver had support for this file there was a driver that
exposed the contents of the vga password register to userspace. It would
present the entire register instead of interpreting it.

The drm implementation chose to mask of the lower bit, without explaining
why. This breaks the existing userspace, which is looking for 0xa8 in
the lower byte.

Change our implementation to expose the entire register.

Fixes: 696029eb

 ("drm/aspeed: Add sysfs for output settings")
Reported-by: default avatarOskar Senft <osk@google.com>
Signed-off-by: default avatarJoel Stanley <joel@jms.id.au>
Reviewed-by: default avatarJeremy Kerr <jk@codeconstruct.com.au>
Tested-by: default avatarOskar Senft <osk@google.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20211117010145.297253-1-joel@jms.id.au


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 55572176
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment