Skip to content
Commit 7b72d661 authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring: gate iowait schedule on having pending requests

A previous commit made all cqring waits marked as iowait, as a way to
improve performance for short schedules with pending IO. However, for
use cases that have a special reaper thread that does nothing but
wait on events on the ring, this causes a cosmetic issue where we
know have one core marked as being "busy" with 100% iowait.

While this isn't a grave issue, it is confusing to users. Rather than
always mark us as being in iowait, gate setting of current->in_iowait
to 1 by whether or not the waiting task has pending requests.

Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/io-uring/CAMEGJJ2RxopfNQ7GNLhr7X9=bHXKo+G5OOe0LUq=+UgLXsv1Xg@mail.gmail.com/
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217699
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217700


Reported-by: default avatarOleksandr Natalenko <oleksandr@natalenko.name>
Reported-by: default avatarPhil Elwell <phil@raspberrypi.com>
Tested-by: default avatarAndres Freund <andres@anarazel.de>
Fixes: 8a796565

 ("io_uring: Use io_schedule* in cqring wait")
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 07e98113
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment