pstore: Switch pmsg_lock to an rt_mutex to avoid priority inversion
Wei Wang reported seeing priority inversion caused latencies caused by contention on pmsg_lock, and suggested it be switched to a rt_mutex. I was initially hesitant this would help, as the tasks in that trace all seemed to be SCHED_NORMAL, so the benefit would be limited to only nice boosting. However, another similar issue was raised where the priority inversion was seen did involve a blocked RT task so it is clear this would be helpful in that case. Cc: Wei Wang <wvw@google.com> Cc: Midas Chien<midaschieh@google.com> Cc: Connor O'Brien <connoro@google.com> Cc: Kees Cook <keescook@chromium.org> Cc: Anton Vorontsov <anton@enomsg.org> Cc: Colin Cross <ccross@android.com> Cc: Tony Luck <tony.luck@intel.com> Cc: kernel-team@android.com Fixes: 9d5438f4 ("pstore: Add pmsg - user-space accessible pstore object") Reported-by:Wei Wang <wvw@google.com> Signed-off-by:
John Stultz <jstultz@google.com> Signed-off-by:
Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20221214231834.3711880-1-jstultz@google.com
parent
e6b84274
-
mentioned in commit 2f4fec59
-
mentioned in commit 41cccae1
-
mentioned in commit 2cd36502
-
mentioned in commit 9a5a230f
-
mentioned in commit 2eb3e8ee
-
mentioned in commit e84276c8
-
mentioned in commit 475add46
-
mentioned in commit d47db733
-
mentioned in commit 1d6fab11
-
mentioned in commit 3869c326
Please register or sign in to comment