Skip to content
Commit 767099f0 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Greg Kroah-Hartman
Browse files

lan743x: fix deadlock in lan743x_phy_link_status_change()

commit ddb826c2 upstream.

Usage of phy_ethtool_get_link_ksettings() in the link status change
handler isn't needed, and in combination with the referenced change
it results in a deadlock. Simply remove the call and replace it with
direct access to phydev->speed. The duplex argument of
lan743x_phy_update_flowcontrol() isn't used and can be removed.

Fixes: c10a485c

 ("phy: phy_ethtool_ksettings_get: Lock the phy for consistency")
Reported-by: default avatarAlessandro B Maurici <abmaurici@gmail.com>
Tested-by: default avatarAlessandro B Maurici <abmaurici@gmail.com>
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/40e27f76-0ba3-dcef-ee32-a78b9df38b0f@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
[dannf: adjust context]
Signed-off-by: default avatardann frazier <dann.frazier@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5d76e0b6
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment