Skip to content
Commit 69d5ff3e authored by Fabian Vogt's avatar Fabian Vogt Committed by Dmitry Torokhov
Browse files

Input: nspire-keypad - enable interrupts only when opened

The driver registers an interrupt handler in _probe, but didn't configure
them until later when the _open function is called. In between, the keypad
can fire an IRQ due to touchpad activity, which the handler ignores. This
causes the kernel to disable the interrupt, blocking the keypad from
working.

Fix this by disabling interrupts before registering the handler.
Additionally, disable them in _close, so that they're only enabled while
open.

Fixes: fc4f3146

 ("Input: add TI-Nspire keypad support")
Signed-off-by: default avatarFabian Vogt <fabian@ritter-vogt.de>
Link: https://lore.kernel.org/r/3383725.iizBOSrK1V@linux-e202.suse.de
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent daa58c8e
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment