test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation
commit 7dae593c upstream. In a couple of situations like name = kstrndup(buf, count, GFP_KERNEL); if (!name) return -ENOSPC; the error is not actually "No space left on device", but "Out of memory". It is semantically correct to return -ENOMEM in all failed kstrndup() and kzalloc() cases in this driver, as it is not a problem with disk space, but with kernel memory allocator failing allocation. The semantically correct should be: name = kstrndup(buf, count, GFP_KERNEL); if (!name) return -ENOMEM; Cc: Dan Carpenter <error27@gmail.com> Cc: Takashi Iwai <tiwai@suse.de> Cc: Kees Cook <keescook@chromium.org> Cc: "Luis R. Rodriguez" <mcgrof@ruslug.rutgers.edu> Cc: Scott Branden <sbranden@broadcom.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Brian Norris <briannorris@chromium.org> Fixes: c92316bf ("test_firmware: add batched firmware tests") Fixes: 0a8adf58 ("test: add firmware_class loader test") Fixes: 548193cb ("test_firmware: add support for firmware_request_platform") Fixes: eb910947 ("test: firmware_class: add asynchronous request trigger") Fixes: 061132d2 ("test_firmware: add test custom fallback trigger") Fixes: 7feebfa4 ("test_firmware: add support for request_firmware_into_buf") Signed-off-by:Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> Reviewed-by:
Dan Carpenter <dan.carpenter@linaro.org> Message-ID: <20230606070808.9300-1-mirsad.todorovac@alu.unizg.hr> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
0ab95d5c
Please register or sign in to comment