net: dsa: microchip: ksz8795: Reject unsupported VLAN configuration
commit 8f4f58f8 upstream. The switches supported by ksz8795 only have a per-port flag for Tag Removal. This means it is not possible to support both tagged and untagged VLANs on the same port. Reject attempts to add a VLAN that requires the flag to be changed, unless there are no VLANs currently configured. VID 0 is excluded from this check since it is untagged regardless of the state of the flag. On the CPU port we could support tagged and untagged VLANs at the same time. This will be enabled by a later patch. Fixes: e66f840c ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver") Signed-off-by:Ben Hutchings <ben.hutchings@mind.be> Signed-off-by:
David S. Miller <davem@davemloft.net> [bwh: Backport to 5.10: - This configuration has to be detected and rejected in the port_vlan_prepare operation - ksz8795_port_vlan_add() has to check again to decide whether to change the Tag Removal flag, so put the common condition in a separate function - Handle VID ranges] Signed-off-by:
Ben Hutchings <ben.hutchings@mind.be> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
60c007b5
Please register or sign in to comment