Skip to content
Commit 4efa386e authored by Jann Horn's avatar Jann Horn Committed by Greg Kroah-Hartman
Browse files

efivars: Respect "block" flag in efivar_entry_set_safe()

commit 258dd902 upstream.

When the "block" flag is false, the old code would sometimes still call
check_var_size(), which wrongly tells ->query_variable_store() that it can
block.

As far as I can tell, this can't really materialize as a bug at the moment,
because ->query_variable_store only does something on X86 with generic EFI,
and in that configuration we always take the efivar_entry_set_nonblocking()
path.

Fixes: ca0e30dc

 ("efi: Add nonblocking option to efi_query_variable_store()")
Signed-off-by: default avatarJann Horn <jannh@google.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20220218180559.1432559-1-jannh@google.com
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 61a30397
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment