Skip to content
Commit 4d8f24ee authored by Wei Wang's avatar Wei Wang Committed by Jakub Kicinski
Browse files

Revert "tcp: change pingpong threshold to 3"

This reverts commit 4a41f453.

This to-be-reverted commit was meant to apply a stricter rule for the
stack to enter pingpong mode. However, the condition used to check for
interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
jiffy based and might be too coarse, which delays the stack entering
pingpong mode.
We revert this patch so that we no longer use the above condition to
determine interactive session, and also reduce pingpong threshold to 1.

Fixes: 4a41f453

 ("tcp: change pingpong threshold to 3")
Reported-by: default avatarLemmyHuang <hlm3280@163.com>
Suggested-by: default avatarNeal Cardwell <ncardwell@google.com>
Signed-off-by: default avatarWei Wang <weiwan@google.com>
Acked-by: default avatarNeal Cardwell <ncardwell@google.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220721204404.388396-1-weiwan@google.com
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8ee18e2a
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment