Skip to content
Commit 4a6756f5 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Philipp Zabel
Browse files

reset: Fix crash when freeing non-existent optional resets

When obtaining one or more optional resets, non-existent resets are
stored as NULL pointers, and all related error and cleanup paths need to
take this into account.

Currently only reset_control_put() and reset_control_bulk_put()
get this right.  All of __reset_control_bulk_get(),
of_reset_control_array_get(), and reset_control_array_put() lack the
proper checking, causing NULL pointer dereferences on failure or
release.

Fix this by moving the existing check from reset_control_bulk_put() to
__reset_control_put_internal(), so it applies to all callers.
The double check in reset_control_put() doesn't hurt.

Fixes: 17c82e20 ("reset: Add APIs to manage array of resets")
Fixes: 48d71395

 ("reset: Add reset_control_bulk API")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/2440edae7ca8534628cdbaf559ded288f2998178.1701276806.git.geert+renesas@glider.be
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent b5ec2944
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment