Skip to content
Commit 31db78a4 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: mac80211: fix potential key use-after-free



When ieee80211_key_link() is called by ieee80211_gtk_rekey_add()
but returns 0 due to KRACK protection (identical key reinstall),
ieee80211_gtk_rekey_add() will still return a pointer into the
key, in a potential use-after-free. This normally doesn't happen
since it's only called by iwlwifi in case of WoWLAN rekey offload
which has its own KRACK protection, but still better to fix, do
that by returning an error code and converting that to success on
the cfg80211 boundary only, leaving the error for bad callers of
ieee80211_gtk_rekey_add().

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Fixes: fdf7cb41

 ("mac80211: accept key reinstall without changing anything")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 684e45e1
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment