Skip to content
Commit 2f734480 authored by Paolo Abeni's avatar Paolo Abeni Committed by Sasha Levin
Browse files

udp: fix race between close() and udp_abort()

[ Upstream commit a8b897c7

 ]

Kaustubh reported and diagnosed a panic in udp_lib_lookup().
The root cause is udp_abort() racing with close(). Both
racing functions acquire the socket lock, but udp{v6}_destroy_sock()
release it before performing destructive actions.

We can't easily extend the socket lock scope to avoid the race,
instead use the SOCK_DEAD flag to prevent udp_abort from doing
any action when the critical race happens.

Diagnosed-and-tested-by: default avatarKaustubh Pandey <kapandey@codeaurora.org>
Fixes: 5d77dca8

 ("net: diag: support SOCK_DESTROY for UDP sockets")
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 06b7cb01
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment