Skip to content
Commit 2350f8a1 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

bpf: Explicitly memset the bpf_attr structure

commit 8096f229

 upstream.

For the bpf syscall, we are relying on the compiler to properly zero out
the bpf_attr union that we copy userspace data into. Unfortunately that
doesn't always work properly, padding and other oddities might not be
correctly zeroed, and in some tests odd things have been found when the
stack is pre-initialized to other values.

Fix this by explicitly memsetting the structure to 0 before using it.

Reported-by: default avatarMaciej Żenczykowski <maze@google.com>
Reported-by: default avatarJohn Stultz <john.stultz@linaro.org>
Reported-by: default avatarAlexander Potapenko <glider@google.com>
Reported-by: default avatarAlistair Delva <adelva@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarYonghong Song <yhs@fb.com>
Link: https://android-review.googlesource.com/c/kernel/common/+/1235490
Link: https://lore.kernel.org/bpf/20200320094813.GA421650@kroah.com
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 27287ca4
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment