Skip to content
Commit 1fc84010 authored by Cong Wang's avatar Cong Wang Committed by Ben Hutchings
Browse files

sch_hhf: ensure quantum and hhf_non_hh_weight are non-zero

commit d4d6ec6d upstream.

In case of TCA_HHF_NON_HH_WEIGHT or TCA_HHF_QUANTUM is zero,
it would make no progress inside the loop in hhf_dequeue() thus
kernel would get stuck.

Fix this by checking this corner case in hhf_change().

Fixes: 10239edf

 ("net-qdisc-hhf: Heavy-Hitter Filter (HHF) qdisc")
Reported-by: default avatar <syzbot+bc6297c11f19ee807dc2@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+041483004a7f45f1f20a@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+55be5f513bed37fc4367@syzkaller.appspotmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Terry Lam <vtlam@google.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 3efd8305
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment