Skip to content
Commit 1616a4c2 authored by Coly Li's avatar Coly Li Committed by Jens Axboe
Browse files

bcache: remove bcache device self-defined readahead



For read cache missing, bcache defines a readahead size for the read I/O
request to the backing device for the missing data. This readahead size
is initialized to 0, and almost no one uses it to avoid unnecessary read
amplifying onto backing device and write amplifying onto cache device.
Considering upper layer file system code has readahead logic allready
and works fine with readahead_cache_policy sysfile interface, we don't
have to keep bcache self-defined readahead anymore.

This patch removes the bcache self-defined readahead for cache missing
request for backing device, and the readahead sysfs file interfaces are
removed as well.

This is the preparation for next patch to fix potential kernel panic due
to oversized request in a simpler method.

Reported-by: default avatarAlexander Ullrich <ealex1979@gmail.com>
Reported-by: default avatarDiego Ercolani <diego.ercolani@gmail.com>
Reported-by: default avatarJan Szubiak <jan.szubiak@linuxpolska.pl>
Reported-by: default avatarMarco Rebhan <me@dblsaiko.net>
Reported-by: default avatarMatthias Ferdinand <bcache@mfedv.net>
Reported-by: default avatarVictor Westerhuis <victor@westerhu.is>
Reported-by: default avatarVojtech Pavlik <vojtech@suse.cz>
Reported-and-tested-by: default avatarRolf Fokkens <rolf@rolffokkens.nl>
Reported-and-tested-by: default avatarThorsten Knabe <linux@thorsten-knabe.de>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Nix <nix@esperi.org.uk>
Cc: Takashi Iwai <tiwai@suse.com>
Link: https://lore.kernel.org/r/20210607125052.21277-2-colyli@suse.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e369edbb
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment