Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"
This reverts commit 1f256578. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was already called (in case of the frontent re-connecting). But also, it _should_ be removed when the vif device is destroyed (for example when unbinding the driver) - otherwise hotplug script would not configure the device whenever it re-appear. Moving removal of the 'hotplug-status' node was a workaround for nothing calling network script after xen-netback module is reloaded. But when vif interface is re-created (on xen-netback unbind/bind for example), the script should be called, regardless of who does that - currently this case is not handled by the toolstack, and requires manual script call. Keeping hotplug-status=connected to skip the call is wrong and leads to not configured interface. More discussion at https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> Reviewed-by: Paul Durrant <paul@xen.org> Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
parent
5facf497
-
mentioned in commit 1306c1bb
-
mentioned in commit 549d889e
-
mentioned in commit 625c04b5
-
mentioned in commit fe39ab30
-
mentioned in commit 5f469346
-
mentioned in commit 60e4e319
-
mentioned in commit c55f34b6
-
mentioned in commit 0f1e7977
-
mentioned in commit 595e3616
-
mentioned in commit 26a6d7d4
Please register or sign in to comment