Skip to content
Commit 046f5b77 authored by Peter S. Housel's avatar Peter S. Housel Committed by Greg Kroah-Hartman
Browse files

brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain

commit 5ea59db8 upstream.

An earlier change to this function (3bdae810) fixed a leak in the
case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the
glom_skb buffer, used for emulating a scattering read, is never used
or referenced after its contents are copied into the destination
buffers, and therefore always needs to be freed by the end of the
function.

Fixes: 3bdae810 ("brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain")
Fixes: a413e39a

 ("brcmfmac: fix brcmf_sdcard_recv_chain() for host without sg support")
Signed-off-by: default avatarPeter S. Housel <housel@acm.org>
Signed-off-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 305b4b1b
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment