Commit ffbf4e14 authored Mar 03, 2022 by Sreekanth Reddy Committed by Baogen Shang Oct 24, 2024

scsi: mpt3sas: Remove scsi_dma_map() error messages

stable inclusion
from stable-v5.10.224
commit 8f209716ea5ec9d954d8f328583245b49d5fd151
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAYWXN
CVE: NA
Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.10.y&id=8f209716ea5ec9d954d8f328583245b49d5fd151

-------------------------

[ Upstream commit 0c25422d ]

When scsi_dma_map() fails by returning a sges_left value less than zero,
the amount of logging produced can be extremely high.  In a recent end-user
environment, 1200 messages per second were being sent to the log buffer.
This eventually overwhelmed the system and it stalled.

These error messages are not needed. Remove them.

Link: https://lore.kernel.org/r/20220303140203.12642-1-sreekanth.reddy@broadcom.com


Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Stable-dep-of: 82dbb57ac8d0 ("scsi: mpt3sas: Avoid IOMMU page faults on REPORT ZONES")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Baogen Shang <baogen.shang@windriver.com>

parent cee28fc9

drivers/scsi/mpt3sas/mpt3sas_base.c

+3 −15

Original line number	Diff line number	Diff line
		@@ -2431,12 +2431,8 @@ _base_check_pcie_native_sgl(struct MPT3SAS_ADAPTER *ioc,

		/* Get the SG list pointer and info. */
		sges_left = scsi_dma_map(scmd);
		if (sges_left < 0) {
		sdev_printk(KERN_ERR, scmd->device,
		"scsi_dma_map failed: request for %d bytes!\n",
		scsi_bufflen(scmd));
		if (sges_left < 0)
		return 1;
		}

		/* Check if we need to build a native SG list. */
		if (base_is_prp_possible(ioc, pcie_device,
		@@ -2543,12 +2539,8 @@ _base_build_sg_scmd(struct MPT3SAS_ADAPTER *ioc,

		sg_scmd = scsi_sglist(scmd);
		sges_left = scsi_dma_map(scmd);
		if (sges_left < 0) {
		sdev_printk(KERN_ERR, scmd->device,
		"scsi_dma_map failed: request for %d bytes!\n",
		scsi_bufflen(scmd));
		if (sges_left < 0)
		return -ENOMEM;
		}

		sg_local = &mpi_request->SGL;
		sges_in_segment = ioc->max_sges_in_main_message;
		@@ -2691,12 +2683,8 @@ _base_build_sg_scmd_ieee(struct MPT3SAS_ADAPTER *ioc,

		sg_scmd = scsi_sglist(scmd);
		sges_left = scsi_dma_map(scmd);
		if (sges_left < 0) {
		sdev_printk(KERN_ERR, scmd->device,
		"scsi_dma_map failed: request for %d bytes!\n",
		scsi_bufflen(scmd));
		if (sges_left < 0)
		return -ENOMEM;
		}

		sg_local = &mpi_request->SGL;
		sges_in_segment = (ioc->request_sz -