Commit 0c25422d authored by Sreekanth Reddy's avatar Sreekanth Reddy Committed by Martin K. Petersen
Browse files

scsi: mpt3sas: Remove scsi_dma_map() error messages 

When scsi_dma_map() fails by returning a sges_left value less than zero,
the amount of logging produced can be extremely high.  In a recent end-user
environment, 1200 messages per second were being sent to the log buffer.
This eventually overwhelmed the system and it stalled.

These error messages are not needed. Remove them.

Link: https://lore.kernel.org/r/20220303140203.12642-1-sreekanth.reddy@broadcom.com


Suggested-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSreekanth Reddy <sreekanth.reddy@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 271add11

drivers/scsi/mpt3sas/mpt3sas_base.c

+3 −15
Original line number Diff line number Diff line
@@ -2593,12 +2593,8 @@ _base_check_pcie_native_sgl(struct MPT3SAS_ADAPTER *ioc, 


	/* Get the SG list pointer and info. */

	sges_left = scsi_dma_map(scmd);

	if (sges_left < 0) {

		sdev_printk(KERN_ERR, scmd->device,

			"scsi_dma_map failed: request for %d bytes!\n",

			scsi_bufflen(scmd));

	if (sges_left < 0)

		return 1;

	}



	/* Check if we need to build a native SG list. */

	if (!base_is_prp_possible(ioc, pcie_device,
@@ -2705,12 +2701,8 @@ _base_build_sg_scmd(struct MPT3SAS_ADAPTER *ioc, 


	sg_scmd = scsi_sglist(scmd);

	sges_left = scsi_dma_map(scmd);

	if (sges_left < 0) {

		sdev_printk(KERN_ERR, scmd->device,

		 "scsi_dma_map failed: request for %d bytes!\n",

		 scsi_bufflen(scmd));

	if (sges_left < 0)

		return -ENOMEM;

	}



	sg_local = &mpi_request->SGL;

	sges_in_segment = ioc->max_sges_in_main_message;
@@ -2853,12 +2845,8 @@ _base_build_sg_scmd_ieee(struct MPT3SAS_ADAPTER *ioc, 


	sg_scmd = scsi_sglist(scmd);

	sges_left = scsi_dma_map(scmd);

	if (sges_left < 0) {

		sdev_printk(KERN_ERR, scmd->device,

			"scsi_dma_map failed: request for %d bytes!\n",

			scsi_bufflen(scmd));

	if (sges_left < 0)

		return -ENOMEM;

	}



	sg_local = &mpi_request->SGL;

	sges_in_segment = (ioc->request_sz -