Commit fd2627a2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jialin Zhang
Browse files

mfd: fsl-imx25: Fix check for platform_get_irq() errors

stable inclusion
from stable-v5.10.150
commit 3469dd8e22ffb0dc446dd0ec36eb5ef51cb5a3d3
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I6D0XA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=3469dd8e22ffb0dc446dd0ec36eb5ef51cb5a3d3



--------------------------------

[ Upstream commit 75db7907 ]

The mx25_tsadc_remove() function assumes all non-zero returns are success
but the platform_get_irq() function returns negative on error and
positive non-zero values on success.  It never returns zero, but if it
did then treat that as a success.

Fixes: 18f77393 ("mfd: fsl-imx25: Clean up irq settings during removal")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarMartin Kaiser <martin@kaiser.cx>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/YvTfkbVQWYKMKS/t@kili


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parent dadc6785
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment