Commit fcde26ba authored by Wei Chen's avatar Wei Chen Committed by sanglipeng
Browse files

wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

stable inclusion
from stable-v5.10.180
commit dc55805db254d7f9990cb5a49dd771e69e70c4ae
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8DDFN

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=dc55805db254d7f9990cb5a49dd771e69e70c4ae



--------------------------------

[ Upstream commit 5dbe1f8e ]

If there is a failure during copy_from_user or user-provided data buffer is
invalid, rtl_debugfs_set_write_reg should return negative error code instead
of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: 610247f4 ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: default avatarWei Chen <harperchen1110@gmail.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230326054217.93492-1-harperchen1110@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 78315d0c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment