Commit fc38a5a1 authored by Yang Yingliang's avatar Yang Yingliang Committed by Ulf Hansson
Browse files

mmc: rtsx_usb_sdmmc: fix return value check of mmc_add_host() 



mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and calling mmc_free_host() in the
error path, besides, led_classdev_unregister() and pm_runtime_disable() also
need be called.

Fixes: c7f6558d ("mmc: Add realtek USB sdmmc host driver")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-7-yangyingliang@huawei.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 0c87db77

drivers/mmc/host/rtsx_usb_sdmmc.c

+10 −1
Original line number Diff line number Diff line
@@ -1329,6 +1329,7 @@ static int rtsx_usb_sdmmc_drv_probe(struct platform_device *pdev) 
#ifdef RTSX_USB_USE_LEDS_CLASS

	int err;

#endif

	int ret;



	ucr = usb_get_intfdata(to_usb_interface(pdev->dev.parent));

	if (!ucr)
@@ -1365,7 +1366,15 @@ static int rtsx_usb_sdmmc_drv_probe(struct platform_device *pdev) 
	INIT_WORK(&host->led_work, rtsx_usb_update_led);



#endif

	mmc_add_host(mmc);

	ret = mmc_add_host(mmc);

	if (ret) {

#ifdef RTSX_USB_USE_LEDS_CLASS

		led_classdev_unregister(&host->led);

#endif

		mmc_free_host(mmc);

		pm_runtime_disable(&pdev->dev);

		return ret;

	}



	return 0;

}