Commit 0c87db77 authored by Yang Yingliang's avatar Yang Yingliang Committed by Ulf Hansson
Browse files

mmc: rtsx_pci: fix return value check of mmc_add_host() 



mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and calling mmc_free_host() in the
error path, beside, runtime PM also needs be disabled.

Fixes: ff984e57 ("mmc: Add realtek pcie sdmmc host driver")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-6-yangyingliang@huawei.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 80e1ef3a

drivers/mmc/host/rtsx_pci_sdmmc.c

+8 −1
Original line number Diff line number Diff line
@@ -1474,6 +1474,7 @@ static int rtsx_pci_sdmmc_drv_probe(struct platform_device *pdev) 
	struct realtek_pci_sdmmc *host;

	struct rtsx_pcr *pcr;

	struct pcr_handle *handle = pdev->dev.platform_data;

	int ret;



	if (!handle)

		return -ENXIO;
@@ -1511,7 +1512,13 @@ static int rtsx_pci_sdmmc_drv_probe(struct platform_device *pdev) 
	pm_runtime_mark_last_busy(&pdev->dev);

	pm_runtime_use_autosuspend(&pdev->dev);



	mmc_add_host(mmc);

	ret = mmc_add_host(mmc);

	if (ret) {

		pm_runtime_dont_use_autosuspend(&pdev->dev);

		pm_runtime_disable(&pdev->dev);

		mmc_free_host(mmc);

		return ret;

	}



	return 0;

}