Commit 80e1ef3a authored by Yang Yingliang's avatar Yang Yingliang Committed by Ulf Hansson
Browse files

mmc: pxamci: fix return value check of mmc_add_host() 



mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and goto error path which will call
mmc_free_host(), besides, ->exit() need be called to uninit the pdata.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-5-yangyingliang@huawei.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent cde600af

drivers/mmc/host/pxamci.c

+6 −1
Original line number Diff line number Diff line
@@ -763,7 +763,12 @@ static int pxamci_probe(struct platform_device *pdev) 
			dev_warn(dev, "gpio_ro and get_ro() both defined\n");

	}



	mmc_add_host(mmc);

	ret = mmc_add_host(mmc);

	if (ret) {

		if (host->pdata && host->pdata->exit)

			host->pdata->exit(dev, mmc);

		goto out;

	}



	return 0;