Commit faae8142 authored by Magnus Karlsson's avatar Magnus Karlsson Committed by Tony Nguyen
Browse files

ixgbevf: add correct exception tracing for XDP 



Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.

Fixes: 21092e9c ("ixgbevf: Add support for XDP_TX action")
Reported-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: default avatarMagnus Karlsson <magnus.karlsson@intel.com>
Tested-by: default avatarVishakha Jambekar <vishakha.jambekar@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 74431c40

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

+3 −0
Original line number Original line Diff line number Diff line
@@ -1067,11 +1067,14 @@ static struct sk_buff *ixgbevf_run_xdp(struct ixgbevf_adapter *adapter, 
	case XDP_TX:

	case XDP_TX:

		xdp_ring = adapter->xdp_ring[rx_ring->queue_index];

		xdp_ring = adapter->xdp_ring[rx_ring->queue_index];

		result = ixgbevf_xmit_xdp_ring(xdp_ring, xdp);

		result = ixgbevf_xmit_xdp_ring(xdp_ring, xdp);

		if (result == IXGBEVF_XDP_CONSUMED)

			goto out_failure;

		break;

		break;

	default:

	default:

		bpf_warn_invalid_xdp_action(act);

		bpf_warn_invalid_xdp_action(act);

		fallthrough;

		fallthrough;

	case XDP_ABORTED:

	case XDP_ABORTED:

out_failure:

		trace_xdp_exception(rx_ring->netdev, xdp_prog, act);

		trace_xdp_exception(rx_ring->netdev, xdp_prog, act);

		fallthrough; /* handle aborts by dropping packet */

		fallthrough; /* handle aborts by dropping packet */

	case XDP_DROP:

	case XDP_DROP: