Commit 74431c40 authored May 10, 2021 by Magnus Karlsson Committed by Tony Nguyen Jun 03, 2021

igb: add correct exception tracing for XDP



Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.

Fixes: 9cbc948b ("igb: add XDP support")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Tested-by: Vishakha Jambekar <vishakha.jambekar@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

parent 8281356b

drivers/net/ethernet/intel/igb/igb_main.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -8394,18 +8394,20 @@ static struct sk_buff igb_run_xdp(struct igb_adapter adapter,
		break;
		case XDP_TX:
		result = igb_xdp_xmit_back(adapter, xdp);
		if (result == IGB_XDP_CONSUMED)
		goto out_failure;
		break;
		case XDP_REDIRECT:
		err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog);
		if (!err)
		if (err)
		goto out_failure;
		result = IGB_XDP_REDIR;
		else
		result = IGB_XDP_CONSUMED;
		break;
		default:
		bpf_warn_invalid_xdp_action(act);
		fallthrough;
		case XDP_ABORTED:
		out_failure:
		trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
		fallthrough;
		case XDP_DROP: