Commit f7559793 authored Nov 06, 2019 by Darrick J. Wong

xfs: annotate functions that trip static checker locking checks



Add some lock annotations to helper functions that seem to have
unbalanced locking that confuses the static analyzers.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent cf085a1b

fs/xfs/xfs_log.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2808,6 +2808,8 @@ xlog_state_do_iclog_callbacks(
		struct xlog *log,
		struct xlog_in_core *iclog,
		bool aborted)
		__releases(&log->l_icloglock)
		__acquires(&log->l_icloglock)
		{
		spin_unlock(&log->l_icloglock);
		spin_lock(&iclog->ic_callback_lock);

fs/xfs/xfs_log_priv.h

+5 −1

Original line number	Diff line number	Diff line
		@@ -537,7 +537,11 @@ xlog_cil_force(struct xlog *log)
		* by a spinlock. This matches the semantics of all the wait queues used in the
		* log code.
		*/
		static inline void xlog_wait(wait_queue_head_t wq, spinlock_t lock)
		static inline void
		xlog_wait(
		struct wait_queue_head *wq,
		struct spinlock *lock)
		__releases(lock)
		{
		DECLARE_WAITQUEUE(wait, current);