Commit f670744a authored by Yang Yingliang's avatar Yang Yingliang Committed by Ulf Hansson
Browse files

mmc: toshsd: fix return value check of mmc_add_host() 



mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and goto error path which will call
mmc_free_host(), besides, free_irq() also needs be called.

Fixes: a5eb8bbd ("mmc: add Toshiba PCI SD controller driver")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-8-yangyingliang@huawei.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent fc38a5a1

drivers/mmc/host/toshsd.c

+5 −1
Original line number Diff line number Diff line
@@ -651,7 +651,9 @@ static int toshsd_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	if (ret)

		goto unmap;



	mmc_add_host(mmc);

	ret = mmc_add_host(mmc);

	if (ret)

		goto free_irq;



	base = pci_resource_start(pdev, 0);

	dev_dbg(&pdev->dev, "MMIO %pa, IRQ %d\n", &base, pdev->irq);
@@ -660,6 +662,8 @@ static int toshsd_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 


	return 0;



free_irq:

	free_irq(pdev->irq, host);

unmap:

	pci_iounmap(pdev, host->ioaddr);

release: