Commit f60542ea authored by Qinglang Miao's avatar Qinglang Miao Committed by Yang Yingliang
Browse files

i2c: xiic: fix reference leak when pm_runtime_get_sync fails

mainline inclusion
from mainline-v5.13-rc1
commit a85c5c7a
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I94JCX
CVE: CVE-2020-36778

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a85c5c7a3aa8041777ff691400b4046e56149fd3



--------------------------------

The PM reference count is not expected to be incremented on
return in xiic_xfer and xiic_i2c_remove.

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 10b17004 ("i2c: xiic: Fix the clocking across bind unbind")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Conflicts:
	drivers/i2c/busses/i2c-xiic.c
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent 101fdd49
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment