Commit f4ebbd66 authored by Martin Povišer's avatar Martin Povišer Committed by sanglipeng
Browse files

ASoC: tas2764: Fix set_tdm_slot in case of single slot

stable inclusion
from stable-v5.10.156
commit f5dedad4059b99ad3f6ce9f9c74c0cf1ea3cb1ea
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7MCG1

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=f5dedad4059b99ad3f6ce9f9c74c0cf1ea3cb1ea



--------------------------------

[ Upstream commit faac764e ]

There's a special branch in the set_tdm_slot op for the case of nslots
being 1, but:

 (1) That branch can never work (there's a check for tx_mask being
     non-zero, later there's another check for it *being* zero; one or
     the other always throws -EINVAL).

 (2) The intention of the branch seems to be what the general other
     branch reduces to in case of nslots being 1.

For those reasons remove the 'nslots being 1' special case.

Fixes: 827ed8a0 ("ASoC: tas2764: Add the driver for the TAS2764")
Suggested-by: default avatarJos Dehaes <jos.dehaes@gmail.com>
Signed-off-by: default avatarMartin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20221027095800.16094-2-povik+lin@cutebit.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 3cb1fb68
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment