Commit f3e29671 authored by Ziyang Xuan's avatar Ziyang Xuan
Browse files

netfilter: nf_tables: Fix potential data-race in __nft_expr_type_get()

stable inclusion
from stable-v4.19.313
commit 939109c0a8e2a006a6cc8209e262d25065f4403a
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9L5P0


CVE: CVE-2024-27020

--------------------------------

[ Upstream commit f969eb84ce482331a991079ab7a5c4dc3b7f89bf ]

nft_unregister_expr() can concurrent with __nft_expr_type_get(),
and there is not any protection when iterate over nf_tables_expressions
list in __nft_expr_type_get(). Therefore, there is potential data-race
of nf_tables_expressions list entry.

Use list_for_each_entry_rcu() to iterate over nf_tables_expressions
list in __nft_expr_type_get(), and use rcu_read_lock() in the caller
nft_expr_type_get() to protect the entire type query process.

Fixes: ef1f7df9 ("netfilter: nf_tables: expression ops overloading")
Signed-off-by: default avatarZiyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZiyang Xuan <william.xuanziyang@huawei.com>
parent 63c94bff
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment