eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write()
stable inclusion from stable-v5.10.137 commit 5bcc37dc246332e42cc2c42bf5e45311711eb20e category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I60PLB Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=5bcc37dc246332e42cc2c42bf5e45311711eb20e -------------------------------- [ Upstream commit 71d46f1f ] The simple_write_to_buffer() function will return positive/success if it is able to write a single byte anywhere within the buffer. However that potentially leaves a lot of the buffer uninitialized. In this code it's better to return 0 if the offset is non-zero. This code is not written to support partial writes. And then return -EFAULT if the buffer is not completely initialized. Fixes: cfad6425 ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") Reviewed-by:Serge Semin <fancer.lancer@gmail.com> Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/Ysg1Pu/nzSMe3r1q@kili Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Sasha Levin <sashal@kernel.org> Signed-off-by:
Zheng Zengkai <zhengzengkai@huawei.com> Reviewed-by:
Wei Li <liwei391@huawei.com>
Loading
Please sign in to comment