Commit f2dcd21d authored by Andi Shyti's avatar Andi Shyti
Browse files

drm/i915/gt: Rename flags with bit_group_X according to the datasheet 



In preparation of the next patch align with the datasheet (BSPEC
47112) with the naming of the pipe control set of flag values.
The variable "flags" in gen12_emit_flush_rcs() is applied as a
set of flags called Bit Group 1.

Define also the Bit Group 0 as bit_group_0 where currently only
PIPE_CONTROL0_HDC_PIPELINE_FLUSH bit is set.

Signed-off-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
Cc: <stable@vger.kernel.org> # v5.8+
Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230725001950.1014671-5-andi.shyti@linux.intel.com
parent ad8ebf12

drivers/gpu/drm/i915/gt/gen8_engine_cs.c

+18 −16
Original line number Diff line number Diff line
@@ -219,7 +219,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) 
	 * table requires quiescing memory traffic beforehand

	 */

	if (mode & EMIT_FLUSH || gen12_needs_ccs_aux_inv(engine)) {

		u32 flags = 0;

		u32 bit_group_0 = 0;

		u32 bit_group_1 = 0;

		int err;

		u32 *cs;
@@ -227,32 +228,33 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) 
		if (err)

			return err;



		flags |= PIPE_CONTROL_TILE_CACHE_FLUSH;

		flags |= PIPE_CONTROL_FLUSH_L3;

		flags |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;

		flags |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;

		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;



		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;

		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;

		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;

		bit_group_1 |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;

		/* Wa_1409600907:tgl,adl-p */

		flags |= PIPE_CONTROL_DEPTH_STALL;

		flags |= PIPE_CONTROL_DC_FLUSH_ENABLE;

		flags |= PIPE_CONTROL_FLUSH_ENABLE;

		bit_group_1 |= PIPE_CONTROL_DEPTH_STALL;

		bit_group_1 |= PIPE_CONTROL_DC_FLUSH_ENABLE;

		bit_group_1 |= PIPE_CONTROL_FLUSH_ENABLE;



		flags |= PIPE_CONTROL_STORE_DATA_INDEX;

		flags |= PIPE_CONTROL_QW_WRITE;

		bit_group_1 |= PIPE_CONTROL_STORE_DATA_INDEX;

		bit_group_1 |= PIPE_CONTROL_QW_WRITE;



		flags |= PIPE_CONTROL_CS_STALL;

		bit_group_1 |= PIPE_CONTROL_CS_STALL;



		if (!HAS_3D_PIPELINE(engine->i915))

			flags &= ~PIPE_CONTROL_3D_ARCH_FLAGS;

			bit_group_1 &= ~PIPE_CONTROL_3D_ARCH_FLAGS;

		else if (engine->class == COMPUTE_CLASS)

			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;

			bit_group_1 &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;



		cs = intel_ring_begin(rq, 6);

		if (IS_ERR(cs))

			return PTR_ERR(cs);



		cs = gen12_emit_pipe_control(cs,

					     PIPE_CONTROL0_HDC_PIPELINE_FLUSH,

					     flags, LRC_PPHWSP_SCRATCH_ADDR);

		cs = gen12_emit_pipe_control(cs, bit_group_0, bit_group_1,

					     LRC_PPHWSP_SCRATCH_ADDR);

		intel_ring_advance(rq, cs);

	}

drivers/gpu/drm/i915/gt/gen8_engine_cs.h

+11 −7
Original line number Diff line number Diff line
@@ -49,25 +49,29 @@ u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs); 
u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg);



static inline u32 *

__gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset)

__gen8_emit_pipe_control(u32 *batch, u32 bit_group_0,

			 u32 bit_group_1, u32 offset)

{

	memset(batch, 0, 6 * sizeof(u32));



	batch[0] = GFX_OP_PIPE_CONTROL(6) | flags0;

	batch[1] = flags1;

	batch[0] = GFX_OP_PIPE_CONTROL(6) | bit_group_0;

	batch[1] = bit_group_1;

	batch[2] = offset;



	return batch + 6;

}



static inline u32 *gen8_emit_pipe_control(u32 *batch, u32 flags, u32 offset)

static inline u32 *gen8_emit_pipe_control(u32 *batch,

					  u32 bit_group_1, u32 offset)

{

	return __gen8_emit_pipe_control(batch, 0, flags, offset);

	return __gen8_emit_pipe_control(batch, 0, bit_group_1, offset);

}



static inline u32 *gen12_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset)

static inline u32 *gen12_emit_pipe_control(u32 *batch, u32 bit_group_0,

					   u32 bit_group_1, u32 offset)

{

	return __gen8_emit_pipe_control(batch, flags0, flags1, offset);

	return __gen8_emit_pipe_control(batch, bit_group_0,

					bit_group_1, offset);

}



static inline u32 *