Commit f1d0d5c9 authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: uas: Drop DID_TARGET_FAILURE use 

DID_TARGET_FAILURE is internal to the SCSI layer. Drivers must not use it
because:

 1. It's not propagated upwards, so SG IO/passthrough users will not see an
    error and think a command was successful.

 2. There is no handling for it in scsi_decide_disposition() so it results
    in entering SCSI error handling.

It looks like the driver wanted a hard failure so this swaps it with
DID_BAD_TARGET which gives us that behavior. The error looks like it's for
a case where the target did not support a TMF we wanted to use (maybe not a
bad target but disappointing so close enough).

Link: https://lore.kernel.org/r/20220812010027.8251-4-michael.christie@oracle.com


Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a6cb5462

drivers/usb/storage/uas.c

+1 −1
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ static bool uas_evaluate_response_iu(struct response_iu *riu, struct scsi_cmnd * 
		set_host_byte(cmnd, DID_OK);

		break;

	case RC_TMF_NOT_SUPPORTED:

		set_host_byte(cmnd, DID_TARGET_FAILURE);

		set_host_byte(cmnd, DID_BAD_TARGET);

		break;

	default:

		uas_log_cmd_state(cmnd, "response iu", response_code);