Commit a6cb5462 authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: storvsc: Drop DID_TARGET_FAILURE use 

DID_TARGET_FAILURE is internal to the SCSI layer. Drivers must not use it
because:

 1. It's not propagated upwards, so SG IO/passthrough users will not see an
    error and think a command was successful.

 2. There is no handling for it in scsi_decide_disposition() so it results
    in the SCSI error handling running.

It looks like the driver wanted a hard failure so swap it with
DID_BAD_TARGET.

Link: https://lore.kernel.org/r/20220812010027.8251-3-michael.christie@oracle.com


Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 00903af9

drivers/scsi/storvsc_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -1029,7 +1029,7 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb, 
	 */

	wrk = kmalloc(sizeof(struct storvsc_scan_work), GFP_ATOMIC);

	if (!wrk) {

		set_host_byte(scmnd, DID_TARGET_FAILURE);

		set_host_byte(scmnd, DID_BAD_TARGET);

		return;

	}