Commit f1681a9a authored by Randolph Maaßen's avatar Randolph Maaßen Committed by Greg Kroah-Hartman
Browse files

serial: serial-tegra: reduce irq-latency after rx errors 



Since dev_err() calls can lead to synchronous writes to another serial
console these calls can provide significant latency during irq-handling
in tegra_uart_isr(). With this latency another interrupt is likely to
apper during handling of the first interrupt, which might lock up the
kernel completely.

These errors are reported to the error counters so converting the
dev_err() to dev_dbg() is appropriate.

Signed-off-by: default avatarRandolph Maaßen <gaireg@gaireg.de>
Link: https://lore.kernel.org/r/20200605145714.9964-1-gaireg@gaireg.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 894b867a

drivers/tty/serial/serial-tegra.c

+3 −3
Original line number Diff line number Diff line
@@ -439,16 +439,16 @@ static char tegra_uart_decode_rx_error(struct tegra_uart_port *tup, 
			/* Overrrun error */

			flag = TTY_OVERRUN;

			tup->uport.icount.overrun++;

			dev_err(tup->uport.dev, "Got overrun errors\n");

			dev_dbg(tup->uport.dev, "Got overrun errors\n");

		} else if (lsr & UART_LSR_PE) {

			/* Parity error */

			flag = TTY_PARITY;

			tup->uport.icount.parity++;

			dev_err(tup->uport.dev, "Got Parity errors\n");

			dev_dbg(tup->uport.dev, "Got Parity errors\n");

		} else if (lsr & UART_LSR_FE) {

			flag = TTY_FRAME;

			tup->uport.icount.frame++;

			dev_err(tup->uport.dev, "Got frame errors\n");

			dev_dbg(tup->uport.dev, "Got frame errors\n");

		} else if (lsr & UART_LSR_BI) {

			/*

			 * Break error