Commit 894b867a authored by Pavel Machek's avatar Pavel Machek Committed by Greg Kroah-Hartman
Browse files

8250-men-mcb: fix signed/unsigned confusion 



get_num_ports returns -ENODEV, and the result is stored in int, so it
should not be unsigned. Zero ports does not seem to make sense, so
make that check consistent.

Signed-off-by: default avatarPavel Machek (CIP) <pavel@denx.de>

Link: https://lore.kernel.org/r/20200606151146.GA10940@amd


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 167cbce2

drivers/tty/serial/8250/8250_men_mcb.c

+2 −2
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ static u32 men_lookup_uartclk(struct mcb_device *mdev) 
	return clkval;

}



static unsigned int get_num_ports(struct mcb_device *mdev,

static int get_num_ports(struct mcb_device *mdev,

				  void __iomem *membase)

{

	switch (mdev->id) {
@@ -140,7 +140,7 @@ static void serial_8250_men_mcb_remove(struct mcb_device *mdev) 
		return;



	num_ports = get_num_ports(mdev, data[0].uart.port.membase);

	if (num_ports < 0 || num_ports > 4) {

	if (num_ports <= 0 || num_ports > 4) {

		dev_err(&mdev->dev, "error retrieving number of ports!\n");

		return;

	}