Unverified Commit f04b4fb4 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Mark Brown
Browse files

ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get() 



The return value of pm_runtime_resume_and_get() needs to be checked to
avoid a usage count imbalance in the error case. This fix is basically
the same as 92c959ba ("reset: renesas: Fix Runtime PM usage"),
and the last step before pm_runtime_resume_and_get() can be annotated
as __must_check.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/9fed506d-b780-55cd-45a4-9bd2407c910f@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4941cd7c

sound/soc/sh/rz-ssi.c

+6 −1
Original line number Diff line number Diff line
@@ -1020,7 +1020,12 @@ static int rz_ssi_probe(struct platform_device *pdev) 


	reset_control_deassert(ssi->rstc);

	pm_runtime_enable(&pdev->dev);

	pm_runtime_resume_and_get(&pdev->dev);

	ret = pm_runtime_resume_and_get(&pdev->dev);

	if (ret < 0) {

		pm_runtime_disable(ssi->dev);

		reset_control_assert(ssi->rstc);

		return dev_err_probe(ssi->dev, ret, "pm_runtime_resume_and_get failed\n");

	}



	spin_lock_init(&ssi->lock);

	dev_set_drvdata(&pdev->dev, ssi);