Commit 92c959ba authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Philipp Zabel
Browse files

reset: renesas: Fix Runtime PM usage 



If pm_runtime_resume_and_get() fails then it returns w/o the RPM usage
counter being incremented. In this case call pm_runtime_put() in
remove() will result in a usage counter imbalance. Therefore check the
return code of pm_runtime_resume_and_get() and bail out in case of error.

Fixes: bee08559 ("reset: renesas: Add RZ/G2L usbphy control driver")
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/ec24e13f-0530-b091-7a08-864577b9b3be@gmail.com


Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 69125b4b

drivers/reset/reset-rzg2l-usbphy-ctrl.c

+6 −1
Original line number Diff line number Diff line
@@ -137,7 +137,12 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev) 
	dev_set_drvdata(dev, priv);



	pm_runtime_enable(&pdev->dev);

	pm_runtime_resume_and_get(&pdev->dev);

	error = pm_runtime_resume_and_get(&pdev->dev);

	if (error < 0) {

		pm_runtime_disable(&pdev->dev);

		reset_control_assert(priv->rstc);

		return dev_err_probe(&pdev->dev, error, "pm_runtime_resume_and_get failed");

	}



	/* put pll and phy into reset state */

	spin_lock_irqsave(&priv->lock, flags);