Commit efb4879f authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Saeed Mahameed
Browse files

net/mlx5e: Use read lock for eswitch get callbacks 



In commit 367dfa12 ("net/mlx5: Remove devl_unlock from
mlx5_eswtich_mode_callback_enter") all functions were converted
to use write lock without relation to their actual purpose.

Change the devlink eswitch getters to use read and not write locks.

Reviewed-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 42cd2004

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

+6 −6
Original line number Diff line number Diff line
@@ -3572,9 +3572,9 @@ int mlx5_devlink_eswitch_mode_get(struct devlink *devlink, u16 *mode) 
	if (IS_ERR(esw))

		return PTR_ERR(esw);



	down_write(&esw->mode_lock);

	down_read(&esw->mode_lock);

	err = esw_mode_to_devlink(esw->mode, mode);

	up_write(&esw->mode_lock);

	up_read(&esw->mode_lock);

	return err;

}
@@ -3672,9 +3672,9 @@ int mlx5_devlink_eswitch_inline_mode_get(struct devlink *devlink, u8 *mode) 
	if (IS_ERR(esw))

		return PTR_ERR(esw);



	down_write(&esw->mode_lock);

	down_read(&esw->mode_lock);

	err = esw_inline_mode_to_devlink(esw->offloads.inline_mode, mode);

	up_write(&esw->mode_lock);

	up_read(&esw->mode_lock);

	return err;

}
@@ -3746,9 +3746,9 @@ int mlx5_devlink_eswitch_encap_mode_get(struct devlink *devlink, 
	if (IS_ERR(esw))

		return PTR_ERR(esw);



	down_write(&esw->mode_lock);

	down_read(&esw->mode_lock);

	*encap = esw->offloads.encap;

	up_write(&esw->mode_lock);

	up_read(&esw->mode_lock);

	return 0;

}