Commit 42cd2004 authored by Maor Dickman's avatar Maor Dickman Committed by Saeed Mahameed
Browse files

net/mlx5e: Remove redundant allocation of spec in create indirect fwd group 



mlx5_add_flow_rules supports creating rules without any matches by passing NULL
pointer instead of spec, if NULL is passed it will use a static empty spec.
This make allocation of spec in mlx5_create_indir_fwd_group unnecessary.

Remove the redundant allocation.

Signed-off-by: default avatarMaor Dickman <maord@nvidia.com>
Reviewed-by: default avatarRoi Dayan <roid@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 521933cd

drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c

+1 −9
Original line number Diff line number Diff line
@@ -212,19 +212,12 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw, 
	int err = 0, inlen = MLX5_ST_SZ_BYTES(create_flow_group_in);

	struct mlx5_flow_destination dest = {};

	struct mlx5_flow_act flow_act = {};

	struct mlx5_flow_spec *spec;

	u32 *in;



	in = kvzalloc(inlen, GFP_KERNEL);

	if (!in)

		return -ENOMEM;



	spec = kvzalloc(sizeof(*spec), GFP_KERNEL);

	if (!spec) {

		kvfree(in);

		return -ENOMEM;

	}



	/* Hold one entry */

	MLX5_SET(create_flow_group_in, in, start_flow_index, MLX5_ESW_INDIR_TABLE_FWD_IDX);

	MLX5_SET(create_flow_group_in, in, end_flow_index, MLX5_ESW_INDIR_TABLE_FWD_IDX);
@@ -240,14 +233,13 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw, 
	dest.vport.num = e->vport;

	dest.vport.vhca_id = MLX5_CAP_GEN(esw->dev, vhca_id);

	dest.vport.flags = MLX5_FLOW_DEST_VPORT_VHCA_ID;

	e->fwd_rule = mlx5_add_flow_rules(e->ft, spec, &flow_act, &dest, 1);

	e->fwd_rule = mlx5_add_flow_rules(e->ft, NULL, &flow_act, &dest, 1);

	if (IS_ERR(e->fwd_rule)) {

		mlx5_destroy_flow_group(e->fwd_grp);

		err = PTR_ERR(e->fwd_rule);

	}



err_out:

	kvfree(spec);

	kvfree(in);

	return err;

}