Commit ee0a735f authored by Sean Anderson's avatar Sean Anderson Committed by Jakub Kicinski
Browse files

net: sunhme: Fix region request 



devm_request_region is for I/O regions. Use devm_request_mem_region
instead.  This fixes the driver failing to probe since 99df45c9
("sunhme: fix an IS_ERR() vs NULL check in probe"), which checked the
result.

Fixes: 914d9b27 ("sunhme: switch to devres")
Signed-off-by: default avatarSean Anderson <seanga2@gmail.com>
Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Link: https://lore.kernel.org/r/20230222204242.2658247-1-seanga2@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent edea0c5a

drivers/net/ethernet/sun/sunhme.c

+4 −2
Original line number Diff line number Diff line
@@ -2894,8 +2894,10 @@ static int happy_meal_pci_probe(struct pci_dev *pdev, 
		goto err_out_clear_quattro;

	}



	hpreg_res = devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),

					pci_resource_len(pdev, 0), DRV_NAME);

	hpreg_res = devm_request_mem_region(&pdev->dev,

					    pci_resource_start(pdev, 0),

					    pci_resource_len(pdev, 0),

					    DRV_NAME);

	if (!hpreg_res) {

		err = -EBUSY;

		dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");