Commit 99df45c9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

sunhme: fix an IS_ERR() vs NULL check in probe 



The devm_request_region() function does not return error pointers, it
returns NULL on error.

Fixes: 914d9b27 ("sunhme: switch to devres")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarSean Anderson <seanga2@gmail.com>
Reviewed-by: default avatarRolf Eike Beer <eike-kernel@sf-tec.de>
Link: https://lore.kernel.org/r/Y0bWzJL8JknX8MUf@kili


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 30e9672a

drivers/net/ethernet/sun/sunhme.c

+2 −2
Original line number Diff line number Diff line
@@ -2896,8 +2896,8 @@ static int happy_meal_pci_probe(struct pci_dev *pdev, 


	hpreg_res = devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),

					pci_resource_len(pdev, 0), DRV_NAME);

	if (IS_ERR(hpreg_res)) {

		err = PTR_ERR(hpreg_res);

	if (!hpreg_res) {

		err = -EBUSY;

		dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");

		goto err_out_clear_quattro;

	}