Commit ea941ac2 authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: idxd: Fix clobbering of SWERR overflow bit on writeback 



Current code blindly writes over the SWERR and the OVERFLOW bits. Write
back the bits actually read instead so the driver avoids clobbering the
OVERFLOW bit that comes after the register is read.

Fixes: bfe1d560 ("dmaengine: idxd: Init and probe for Intel data accelerators")
Reported-by: default avatarSanjay Kumar <sanjay.k.kumar@intel.com>
Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/161352082229.3511254.1002151220537623503.stgit@djiang5-desk3.ch.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 868833fb

drivers/dma/idxd/irq.c

+3 −1
Original line number Diff line number Diff line
@@ -124,7 +124,9 @@ static int process_misc_interrupts(struct idxd_device *idxd, u32 cause) 
		for (i = 0; i < 4; i++)

			idxd->sw_err.bits[i] = ioread64(idxd->reg_base +

					IDXD_SWERR_OFFSET + i * sizeof(u64));

		iowrite64(IDXD_SWERR_ACK, idxd->reg_base + IDXD_SWERR_OFFSET);



		iowrite64(idxd->sw_err.bits[0] & IDXD_SWERR_ACK,

			  idxd->reg_base + IDXD_SWERR_OFFSET);



		if (idxd->sw_err.valid && idxd->sw_err.wq_idx_valid) {

			int id = idxd->sw_err.wq_idx;