Commit 868833fb authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Vinod Koul
Browse files

dmaengine: xilinx: dpdma: Fix race condition in done IRQ 



The active descriptor pointer is accessed from different contexts,
including different interrupt handlers, and its access must be protected
by the channel's lock. This wasn't done in the done IRQ handler. Fix it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20210307040629.29308-3-laurent.pinchart@ideasonboard.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 1cbd4466

drivers/dma/xilinx/xilinx_dpdma.c

+2 −1
Original line number Diff line number Diff line
@@ -1048,13 +1048,14 @@ static int xilinx_dpdma_chan_stop(struct xilinx_dpdma_chan *chan) 
 */

static void xilinx_dpdma_chan_done_irq(struct xilinx_dpdma_chan *chan)

{

	struct xilinx_dpdma_tx_desc *active = chan->desc.active;

	struct xilinx_dpdma_tx_desc *active;

	unsigned long flags;



	spin_lock_irqsave(&chan->lock, flags);



	xilinx_dpdma_debugfs_desc_done_irq(chan);



	active = chan->desc.active;

	if (active)

		vchan_cyclic_callback(&active->vdesc);

	else