soc: sunxi: sram: Fix probe function ordering issues
stable inclusion from stable-v5.10.147 commit 4e2ede7cb9b5d4950d8e837d50a480250752f2d1 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I6D0W8 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4e2ede7cb9b5d4950d8e837d50a480250752f2d1 -------------------------------- [ Upstream commit 49fad91a ] Errors from debugfs are intended to be non-fatal, and should not prevent the driver from probing. Since debugfs file creation is treated as infallible, move it below the parts of the probe function that can fail. This prevents an error elsewhere in the probe function from causing the file to leak. Do the same for the call to of_platform_populate(). Finally, checkpatch suggests an octal literal for the file permissions. Fixes: 4af34b57 ("drivers: soc: sunxi: Introduce SoC driver to map SRAMs") Fixes: 5828729b ("soc: sunxi: export a regmap for EMAC clock reg on A64") Reviewed-by:Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by:
Samuel Holland <samuel@sholland.org> Tested-by:
Heiko Stuebner <heiko@sntech.de> Signed-off-by:
Jernej Skrabec <jernej.skrabec@gmail.com> Link: https://lore.kernel.org/r/20220815041248.53268-6-samuel@sholland.org Signed-off-by:
Sasha Levin <sashal@kernel.org> Signed-off-by:
Jialin Zhang <zhangjialin11@huawei.com> Reviewed-by:
Zheng Zengkai <zhengzengkai@huawei.com>
Loading
Please sign in to comment