Commit e831b695 authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

staging: vchiq_core: fix type of parameter localport 



The whole vchiq driver uses unsigned int for "localport" except of
find_service_by_port(). So fix this and get the rid of this suspicous
cast.

Reviewed-by: default avatarNicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/1642968143-19281-8-git-send-email-stefan.wahren@i2se.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fd0be0f9

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

+3 −3
Original line number Diff line number Diff line
@@ -255,9 +255,9 @@ find_service_by_handle(unsigned int handle) 
}



struct vchiq_service *

find_service_by_port(struct vchiq_state *state, int localport)

find_service_by_port(struct vchiq_state *state, unsigned int localport)

{

	if ((unsigned int)localport <= VCHIQ_PORT_MAX) {

	if (localport <= VCHIQ_PORT_MAX) {

		struct vchiq_service *service;



		rcu_read_lock();
@@ -271,7 +271,7 @@ find_service_by_port(struct vchiq_state *state, int localport) 
		rcu_read_unlock();

	}

	vchiq_log_info(vchiq_core_log_level,

		       "Invalid port %d", localport);

		       "Invalid port %u", localport);

	return NULL;

}

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h

+1 −1
Original line number Diff line number Diff line
@@ -524,7 +524,7 @@ extern struct vchiq_service * 
find_service_by_handle(unsigned int handle);



extern struct vchiq_service *

find_service_by_port(struct vchiq_state *state, int localport);

find_service_by_port(struct vchiq_state *state, unsigned int localport);



extern struct vchiq_service *

find_service_for_instance(struct vchiq_instance *instance, unsigned int handle);