Commit fd0be0f9 authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

staging: vchiq: add message handling to TODO list 



Recently Arnd Bergmann noticed that the message handling looks broken
to him. So add this point on the TODO list.

Reviewed-by: default avatarNicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/1642968143-19281-7-git-send-email-stefan.wahren@i2se.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fcaaed7c

drivers/staging/vc04_services/interface/TODO

+9 −0
Original line number Diff line number Diff line
@@ -62,3 +62,12 @@ number of devices probed. 
* Clean up Sparse warnings from __user annotations. See

vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter"

is never disclosed to userspace.



* Fix behavior of message handling



The polling behavior of vchiq_bulk_transmit(), vchiq_bulk_receive() and

vchiq_queue_kernel_message() looks broken. A possible signal should be

propagated back to user space to let the calling task handle it before

retrying. Hopefully these msleep(1) shouldn't be necessary anymore.



https://lore.kernel.org/linux-staging/CAK8P3a3HGm1cPo4sW9fOY4E8AN8yAq3tevXxU5m8bmtmsU8WKw@mail.gmail.com/