Commit e8071845 authored by David E. Box's avatar David E. Box Committed by jiayingbao
Browse files

platform/x86/intel/vsec: Fix xa_alloc memory leak

mainline inclusion
from mainline-v6.7-rc2
commit 8cbcc1dbf8a62c730fadd60de761e0658547a589
category: feature
bugzilla: https://gitee.com/openeuler/intel-kernel/issues/I8WOEO

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8cbcc1dbf8a62c730fadd60de761e0658547a589



-------------------------------------

Commit 936874b7 ("platform/x86/intel/vsec: Add PCI error recovery
support to Intel PMT") added an xarray to track the list of vsec devices to
be recovered after a PCI error. But it did not provide cleanup for the list
leading to a memory leak that was caught by kmemleak.  Do xa_alloc() before
devm_add_action_or_reset() so that the list may be cleaned up with
xa_erase() in the release function.

Intel-SIG: commit 8cbcc1dbf8a6 platform/x86/intel/vsec: Fix xa_alloc memory leak
Backport Intel_tpmi base driver.

Fixes: 936874b7 ("platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT")
Signed-off-by: default avatarDavid E. Box <david.e.box@linux.intel.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231129222132.2331261-2-david.e.box@linux.intel.com


[hdegoede@redhat.com: Add missing xa_erase() on error-exit
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
[ Yingbao Jia: amend commit log ]
Signed-off-by: default avatarYingbao Jia <yingbao.jia@intel.com>
parent 1e6e498c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment