Commit e64daad6 authored by Adrian Hunter's avatar Adrian Hunter Committed by Greg Kroah-Hartman
Browse files

driver core: Prevent warning when removing a device link from unregistered consumer 



sysfs_remove_link() causes a warning if the parent directory does not
exist. That can happen if the device link consumer has not been registered.
So do not attempt sysfs_remove_link() in that case.

Fixes: 287905e6 ("driver core: Expose device link details in sysfs")
Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org # 5.9+
Reviewed-by: default avatarRafael J. Wysocki <rafael@kernel.org>
Link: https://lore.kernel.org/r/20210716114408.17320-2-adrian.hunter@intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4afa0c22

drivers/base/core.c

+4 −2
Original line number Diff line number Diff line
@@ -574,8 +574,10 @@ static void devlink_remove_symlinks(struct device *dev, 
		return;

	}



	if (device_is_registered(con)) {

		snprintf(buf, len, "supplier:%s:%s", dev_bus_name(sup), dev_name(sup));

		sysfs_remove_link(&con->kobj, buf);

	}

	snprintf(buf, len, "consumer:%s:%s", dev_bus_name(con), dev_name(con));

	sysfs_remove_link(&sup->kobj, buf);

	kfree(buf);